Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#5699:adding the javax maven dependency to avoid "javax.annotation.Ge… #5702

Merged
merged 1 commit into from May 14, 2019

Conversation

@FuncGuy
Copy link
Contributor

commented Apr 18, 2019

fixed the issue annotation not found compiler error.

@headius

This comment has been minimized.

Copy link
Member

commented Apr 19, 2019

👍

@mkristian

This comment has been minimized.

Copy link
Member

commented Apr 23, 2019

@FuncGuy dependency should be scope provided as we do not need this for runtime only for compile time.
BTW please change core/pom.rb, run build and then core/pom.xml will be generated with the changes from core/pom.rb.

@headius headius added this to the JRuby 9.2.8.0 milestone Apr 25, 2019

@headius

This comment has been minimized.

Copy link
Member

commented May 14, 2019

Since @FuncGuy seems to have gone away I'll merge and fix @mkristian comments on master.

@headius headius merged commit 9d41f4d into jruby:master May 14, 2019

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
jruby.jruby Build #20190418.5 succeeded
Details
@headius

This comment has been minimized.

Copy link
Member

commented May 14, 2019

@FuncGuy Ok I was confused when I merged this...the changes in your PR don't actually do anything with the annotation API.

I did a subsequent commit that removed the dependency and plugin you added, and moved the annotation API dependency (which we already had) to the global space so it's active for all profiles of the build.

If this doesn't work you'll need to explain why these other two changes were needed. Please open a new issue for them that describes why you made them.

@FuncGuy

This comment has been minimized.

Copy link
Contributor Author

commented May 15, 2019

@headius Ok i will try to reproduce if at all possible, i'm ok with your fix!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.