Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ji] to_time conversion for Java DateTime types #5703

Merged
merged 2 commits into from Apr 30, 2019

Conversation

@kares
Copy link
Member

commented Apr 18, 2019

should be good to go, a further extension would be to have a to_date for Java date types

@kares kares added this to the JRuby 9.2.8.0 milestone Apr 18, 2019

@kares kares force-pushed the kares:ji-time-conv branch from d9a9597 to f92eb12 Apr 23, 2019

@headius

This comment has been minimized.

Copy link
Member

commented Apr 26, 2019

@kares This looks fine to me, and I know having stuff in Ruby hurts startup, but I am reluctant to keep adding these extensions in Java. Maybe it's not a huge deal...there's going to be a small number of core JDK types we want to be able to easily roundtrip.

@kares

This comment has been minimized.

Copy link
Member Author

commented Apr 26, 2019

it wont load on startup, we lazy add these as the Java class gets used. so adding more of these wont hurt startup performance

@kares kares merged commit d526bcd into jruby:master Apr 30, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
jruby.jruby Build #20190423.5 succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.