Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix so require_relative can handle an absolute path. #571

Merged
merged 1 commit into from Mar 22, 2013

Conversation

Projects
None yet
2 participants
@yb66
Copy link
Contributor

yb66 commented Mar 10, 2013

require_relative was failing for me when passed an absolute path to a file. I've updated the specs on rubyspecs because they weren't checking for an absolute path being passed (commit #95e39ad659).

The code I've changed here was concatenating an absolute path to either another absolute path (where it failed), or it still left dots in the path (which seemed strange), before passing it to require. I've updated it, but I can't run a high enough version of ant on my machine to run the specs against it (the curse of Apple). Hopefully it works, apologies if not.

Regards,
Iain

Iain Barnett
require_relative fails when passed an absolute path. Changes mean it …
…should now handle both relative and absolute without errors.

headius added a commit that referenced this pull request Mar 22, 2013

Merge pull request #571 from yb66/require_relative
Fix so require_relative can handle an absolute path.

@headius headius merged commit e6fcf42 into jruby:master Mar 22, 2013

1 check failed

default The Travis build failed
Details
@headius

This comment has been minimized.

Copy link
Member

headius commented Mar 22, 2013

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.