Fix indexOf() RubyString method. #5715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
look at CI, the change caused regressions: https://api.travis-ci.org/v3/job/524627557/log.txt (scroll at end) |
|
Thanks for the heads up, kares. I am closing this PR since my fix created another issue and needs to be investigated. I will resubmit a PR when it is done. |
|
Hi @kares, I've fixed what was causing issue but tests are still failing. I am not able to reproduce these errors locally. Any idea of what could cause with these CI regressions? |
|
thanks - seems better. restarted some jobs. |
|
Sure, I just moved the tests. Thanks! |
headius
approved these changes
May 14, 2019
|
Looks ok to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a possible fix for #5714 (Issue when splitting an encoded string with specific characters).
Please, refer to this issue for details.
resolves #5714