Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and deprecate Java interface constant accessors #5731

Merged
merged 2 commits into from May 15, 2019

Conversation

@headius
Copy link
Member

commented May 15, 2019

This fixes #5730 and deprecates the behavior in question (accessing Java interface constant fields using Ruby accessor-style syntax).

We will remove this unintended behavior in 9.3.

@headius headius added this to the JRuby 9.2.8.0 milestone May 15, 2019

@headius headius requested review from enebo and kares May 15, 2019

@headius headius force-pushed the headius:deprecate_constant_accessors branch from f942ed6 to 56e7348 May 15, 2019

@headius

This comment has been minimized.

Copy link
Member Author

commented May 15, 2019

Time marches on...@kares @enebo you can review on master. 😁

@headius headius merged commit 554b2f1 into jruby:master May 15, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
jruby.jruby Build #20190515.6 succeeded
Details

@headius headius deleted the headius:deprecate_constant_accessors branch May 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.