Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use external when windows filesystem encoding is not found #5733

Merged
merged 2 commits into from May 17, 2019

Conversation

@headius
Copy link
Member

commented May 15, 2019

If the file.encoding property does not point at an encoding we recognize, such as "MS950" from #5707, we would hard error during JRuby initialization. This PR modifies that behavior to fall back on whatever we determine is the default external encoding.

This mitigates the error seen in #5707 but it may not match CRuby behavior exactly.

cc @enebo @lopex

@headius headius added this to the JRuby 9.2.8.0 milestone May 15, 2019

@headius headius force-pushed the headius:default_windows_filesystem_encoding branch from bf8cf1e to d015f56 May 16, 2019

@headius headius merged commit 1adb37f into jruby:master May 17, 2019

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
jruby.jruby Build #20190516.2 succeeded
Details

@headius headius deleted the headius:default_windows_filesystem_encoding branch May 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.