Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for IO::for_fd on windows after jnr-enxio#32 #5774

Merged
merged 1 commit into from Aug 1, 2019

Conversation

@byteit101
Copy link
Member

commented Jun 27, 2019

Once jnr/jnr-enxio#32 is merged, this change will enable support for IO::for_fd in windows. See other PR for test details. Tested on Win10 x64

@byteit101 byteit101 referenced this pull request Jul 22, 2019

Open

Use native IO objects & support blocking IO #50

1 of 4 tasks complete

@headius headius added this to the JRuby 9.2.8.0 milestone Aug 1, 2019

@headius headius merged commit 44b4972 into jruby:master Aug 1, 2019

1 of 2 checks passed

jruby.jruby Build #20190627.1 failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@headius

This comment has been minimized.

Copy link
Member

commented Aug 1, 2019

This is pretty localized so I'm merging it in for 9.2.8. I am curious what code needed for_fd on Windows...can you remind me?

@headius

This comment has been minimized.

Copy link
Member

commented Aug 1, 2019

Answer to my query on matrix: hybridgroup/rubyserial#50

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.