Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MRI compatibility with IO::sysopen for serial ports on windows #5809

Merged
merged 3 commits into from Aug 2, 2019

Conversation

@byteit101
Copy link
Member

commented Aug 1, 2019

These changes make JRuby be compatible with MRI's API's and behaviors on Windows serial ports.

Fileno is now real in most cases, but lazily generated in most cases to avoid sucking up 2x the number of file resources.

I put the WinC interface in FilenoUtils arbitrarily, I wasn't sure the best place to put it

byteit101 added some commits Jun 27, 2019

MRI compatibility with sysopen and fileno on windows returning the c …
…handle instead of fake handles.

Lazily create to avoid taking too many resources.
@headius
Copy link
Member

left a comment

Seems ok but need to ensure this falls back to old behavior gracefully when native support is disabled (-Xnative.enabled=false or JVM -Djruby.native.enabled=false).

@headius

headius approved these changes Aug 2, 2019

@headius headius added this to the JRuby 9.2.8.0 milestone Aug 2, 2019

@enebo enebo merged commit 7b6946c into jruby:master Aug 2, 2019

1 of 2 checks passed

jruby.jruby Build #20190801.10 failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.