Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Enumerable#first block signature (matches MRI) #5812

Merged
merged 5 commits into from Aug 5, 2019

Conversation

@kares
Copy link
Member

commented Aug 2, 2019

we can than remove the hack from #2458

... and get some reported (Enumerator) behaviour to work properly, namely :

  • fixes #5044
  • #4108 seems working, except Enumerator.new {|y| y.yield([1])}.lazy.map {|e| e}.to_a

kares added some commits Aug 1, 2019

fix Enumerable#first block signature (matches MRI)
seems we can than eliminate the Yielder#<< hack
[test] some asserts from GH-5044 and GH-4108
also from comments GH-3814 which are now passing

`Enumerator.new { |y| y.yield([1]) }.lazy.map { |e| e }.to_a`
seems to be left not working as in MRI
@kares

This comment has been minimized.

Copy link
Member Author

commented Aug 2, 2019

its pretty much just: efd997d#diff-f67f366aa306d84a4fc25d3cd8f340b8R409
... feels like I might be missing smt here, since that resolves the Enumerator backed first issues

[refactor] actually re-use (duplicate) adjust args helper
... and move the heavy lifting `isFixed()` condition last

@kares kares added this to the JRuby 9.2.8.0 milestone Aug 2, 2019

@kares

This comment has been minimized.

Copy link
Member Author

commented Aug 2, 2019

targeting 9.2.8.0 since #5044 is targeted for 9.2.8.0 atm

@kares kares requested a review from headius Aug 5, 2019

@headius

headius approved these changes Aug 5, 2019

@enebo enebo merged commit 96d8c16 into master Aug 5, 2019

2 of 3 checks passed

jruby.jruby Build #20190802.2 failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@kares kares deleted the enum-yield branch Aug 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.