Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Enumerable#first block signature (matches MRI) #5812

Merged
merged 5 commits into from Aug 5, 2019
Merged

[fix] Enumerable#first block signature (matches MRI) #5812

merged 5 commits into from Aug 5, 2019

Conversation

@kares
Copy link
Member

@kares kares commented Aug 2, 2019

we can than remove the hack from #2458

... and get some reported (Enumerator) behaviour to work properly, namely :

  • fixes #5044
  • #4108 seems working, except Enumerator.new {|y| y.yield([1])}.lazy.map {|e| e}.to_a
kares added 4 commits Aug 2, 2019
seems we can than eliminate the Yielder#<< hack
also from comments GH-3814 which are now passing

`Enumerator.new { |y| y.yield([1]) }.lazy.map { |e| e }.to_a`
seems to be left not working as in MRI
@kares
Copy link
Member Author

@kares kares commented Aug 2, 2019

its pretty much just: efd997d#diff-f67f366aa306d84a4fc25d3cd8f340b8R409
... feels like I might be missing smt here, since that resolves the Enumerator backed first issues

Loading

... and move the heavy lifting `isFixed()` condition last
@kares kares added this to the JRuby 9.2.8.0 milestone Aug 2, 2019
@kares
Copy link
Member Author

@kares kares commented Aug 2, 2019

targeting 9.2.8.0 since #5044 is targeted for 9.2.8.0 atm

Loading

@kares kares requested a review from headius Aug 5, 2019
headius
headius approved these changes Aug 5, 2019
@enebo enebo merged commit 96d8c16 into master Aug 5, 2019
2 of 3 checks passed
Loading
@kares kares deleted the enum-yield branch Aug 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants