Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to backtrace #5851

Merged
merged 1 commit into from Aug 28, 2019
Merged

Improvements to backtrace #5851

merged 1 commit into from Aug 28, 2019

Conversation

@headius
Copy link
Member

headius commented Aug 28, 2019

This PR includes improvements to how we manage the Ruby backtrace. It will fix #5849 among others.

@headius

This comment has been minimized.

Copy link
Member Author

headius commented Aug 28, 2019

The first commit removes backtrace and frame push/pop around loads of Ruby code. Ruby code in all execution modes pushes its own frame and backtrace, so this is unnecessary and messes up backtraces.

The backtrace pushes here are not needed, since the interpreter
pushes its own backtrace (in INTERPRET_ROOT) and AOT code uses
the Java stacktrace.

The frame pushes are moved into the interpreter, since the JIT
does not need them.
@headius headius force-pushed the headius:backtrace_fixes branch from 4411288 to 20e0c0e Aug 28, 2019
@headius headius added this to the JRuby 9.2.9.0 milestone Aug 28, 2019
@headius headius merged commit a4a79cf into jruby:master Aug 28, 2019
5 checks passed
5 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jruby.jruby Build #20190828.4 succeeded
Details
jruby.jruby (Job linux) Job linux succeeded
Details
jruby.jruby (Job mac) Job mac succeeded
Details
jruby.jruby (Job windows) Job windows succeeded
Details
@headius headius deleted the headius:backtrace_fixes branch Aug 28, 2019
headius added a commit that referenced this pull request Aug 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

1 participant
You can’t perform that action at this time.