Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
attempt to share loader for JIT-ed classes #5880
most of it is making
the SHARED_SOURCE was so far only tested with jruby's test suite, the JITed class-loader count went down to 10% ... and meta-space was much less fragmented - saving around 8% of allocated space.
was not sure whether we should attempt to somehow detect
also if you have suggestions for better naming the option or the enum values.
headius left a comment
This all seems good to me!
I don't know what to say about eval methods; in order for them to be a problem, they'd have to:
On the flip side, many methods get generated using eval in a "safe" way (only once, usually to lazily metaprogram some methods) and we definitely want those to be eligible for JIT without a whole separate classloader (when running in a shared mode).
I think we go with this for now as-is. Folks that opt into shared classloading can help us uncover any weird eval edge cases.