Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

frozen path helper #5884

Merged
merged 1 commit into from Sep 23, 2019
Merged

frozen path helper #5884

merged 1 commit into from Sep 23, 2019

Conversation

@ahorek
Copy link
Contributor

ahorek commented Sep 20, 2019

references
https://travis-ci.org/puma/puma/jobs/587423508
puma/puma@c68dfff

FrozenError: can't modify frozen String
  org/jruby/RubyString.java:2684:in `<<'
  uri:classloader:/jruby/path_helper.rb:59:in `block in quote_sensitive_split'
  org/jruby/RubyString.java:5645:in `each_char'
  uri:classloader:/jruby/path_helper.rb:19:in `quote_sensitive_split'
  uri:classloader:/jruby/path_helper.rb:94:in `smart_split_command'
  org/jruby/RubyKernel.java:1780:in `_exec_internal'
  uri:classloader:/jruby/kernel/kernel.rb:4:in `exec'
  /home/travis/.rvm/gems/jruby-head/gems/bundler-2.0.2/lib/bundler/cli/exec.rb:53:in `kernel_exec'
  /home/travis/.rvm/gems/jruby-head/gems/bundler-2.0.2/lib/bundler/cli/exec.rb:34:in `run'
  /home/travis/.rvm/gems/jruby-head/gems/bundler-2.0.2/lib/bundler/cli.rb:465:in `exec'
  /home/travis/.rvm/gems/jruby-head/gems/bundler-2.0.2/lib/bundler/vendor/thor/lib/thor/command.rb:27:in `run'
  /home/travis/.rvm/gems/jruby-head/gems/bundler-2.0.2/lib/bundler/vendor/thor/lib/thor/invocation.rb:126:in `invoke_command'
  /home/travis/.rvm/gems/jruby-head/gems/bundler-2.0.2/lib/bundler/vendor/thor/lib/thor.rb:387:in `dispatch'
  /home/travis/.rvm/gems/jruby-head/gems/bundler-2.0.2/lib/bundler/cli.rb:27:in `dispatch'
  /home/travis/.rvm/gems/jruby-head/gems/bundler-2.0.2/lib/bundler/vendor/thor/lib/thor/base.rb:466:in `start'
  /home/travis/.rvm/gems/jruby-head/gems/bundler-2.0.2/lib/bundler/cli.rb:18:in `start'
  /home/travis/.rvm/gems/jruby-head/gems/bundler-2.0.2/exe/bundle:30:in `block in <main>'
  /home/travis/.rvm/gems/jruby-head/gems/bundler-2.0.2/lib/bundler/friendly_errors.rb:124:in  with_friendly_errors'
  /home/travis/.rvm/gems/jruby-head/gems/bundler-2.0.2/exe/bundle:22:in `<main>'
  org/jruby/RubyKernel.java:1028:in `load'
  /home/travis/.rvm/gems/jruby-head/bin/bundle:23:in `<main>'
  org/jruby/RubyKernel.java:1067:in `eval'
  /home/travis/.rvm/gems/jruby-head/bin/jruby_executable_hooks:24:in `<main>'
pavel
@enebo enebo added this to the JRuby 9.2.9.0 milestone Sep 23, 2019
@enebo enebo merged commit 10e365c into jruby:master Sep 23, 2019
5 checks passed
5 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jruby.jruby Build #20190920.1 succeeded
Details
jruby.jruby (Job linux) Job linux succeeded
Details
jruby.jruby (Job mac) Job mac succeeded
Details
jruby.jruby (Job windows) Job windows succeeded
Details
@enebo

This comment has been minimized.

Copy link
Member

enebo commented Sep 23, 2019

@ahorek I do wonder if puma should be expecting it to be mutable in the first place but it is easy to land this. As it exists today it was a mutable string already so no real semantic change.

@ahorek

This comment has been minimized.

Copy link
Contributor Author

ahorek commented Sep 23, 2019

if you enable --enable-frozen-string-literal globally, you expect that all files are frozen-string-literals friendly, but in this case the core of jruby isn't.

@enebo

This comment has been minimized.

Copy link
Member

enebo commented Sep 23, 2019

@ahorek hah. wow I misread this yeah we are using the shovel to modify the last element. Ignore my comment :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.