Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign up[fix] jit.excludes for block using class (and method) name #5893
Conversation
wasn't working since the (internal) closure id was returned since block tasks will know the impl module - return that and use the common logic for extracting owner name from it
no longer exclude using internal id - limited usefulness
kares
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
kares commentedSep 26, 2019
wasn't working since the (internal) closure id was returned
since block tasks will know the impl module - return that
and use the common logic for extracting owner name