Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Implement Java::JavaLang::Throwable#full_message #5908
Since Java throwables are treated similarly to regular Ruby exceptions,
This moves the
Since Java throwables are treated similarly to regular Ruby exceptions, I think it makes sense to implement `full_message` for easier logging and debugging. This moves the `RubyException` implementation to `TraceType` so that it can be shared with `Throwable`. I had to change the `exception` argument type in `printBacktraceMRI` in order to support the exception-like object that `Throwable` provides. Closes: #5906
Looks good to me. The whitespace changes are a little annoying, but the whitespace that was there shouldn't have been. If you do any future PRs, try to keep the whitespace changes in a separate commit, so they don't show up in git blame as being related to the actual change.
Thank you for the patch!