Add native.popen option to disable native popen. #5921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our native subprocess logic has some quirks, and for cases where it is a problem like jruby#5911 it would be good to be able to disable native popen/spawn/backquote without disabling all of native support. This PR adds the property `jruby.native.popen` defaulting to true. Users can force the use of the built-in JDK process logic by passing `-Xnative.popen=false` to JRuby or passing to the JVM `-Djruby.native.popen=false`.
AlexEzzeddine
pushed a commit
to GoshPosh/jruby
that referenced
this issue
Oct 23, 2019
Add native.popen option to disable native popen. # Conflicts: # core/src/main/java/org/jruby/util/cli/Options.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Our native subprocess logic has some quirks, and for cases where
it is a problem like #5911 it would be good to be able to disable
native popen/spawn/backquote without disabling all of native
support. This PR adds the property
jruby.native.popendefaultingto true. Users can force the use of the built-in JDK process logic
by passing
-Xnative.popen=falseto JRuby or passingto the JVM
-Djruby.native.popen=false.