Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add native.popen option to disable native popen. #5921

Merged
merged 1 commit into from Oct 23, 2019

Conversation

headius
Copy link
Member

@headius headius commented Oct 18, 2019

Our native subprocess logic has some quirks, and for cases where
it is a problem like #5911 it would be good to be able to disable
native popen/spawn/backquote without disabling all of native
support. This PR adds the property jruby.native.popen defaulting
to true. Users can force the use of the built-in JDK process logic
by passing -Xnative.popen=false to JRuby or passing
to the JVM -Djruby.native.popen=false.

Our native subprocess logic has some quirks, and for cases where
it is a problem like jruby#5911 it would be good to be able to disable
native popen/spawn/backquote without disabling all of native
support. This PR adds the property `jruby.native.popen` defaulting
to true. Users can force the use of the built-in JDK process logic
by passing `-Xnative.popen=false` to JRuby or passing
to the JVM `-Djruby.native.popen=false`.
@headius headius added this to the JRuby 9.2.9.0 milestone Oct 18, 2019
@headius headius merged commit 6f78f04 into jruby:master Oct 23, 2019
5 checks passed
@headius headius deleted the disable_native_popen branch Oct 23, 2019
AlexEzzeddine pushed a commit to GoshPosh/jruby that referenced this issue Oct 23, 2019
Add native.popen option to disable native popen.
# Conflicts:
#	core/src/main/java/org/jruby/util/cli/Options.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant