Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure indy-based math binding. #5939

Merged
merged 1 commit into from
Oct 24, 2019

Conversation

headius
Copy link
Member

@headius headius commented Oct 23, 2019

This primarily adds a hard RubyFixnum or RubyFloat type check on
self, to ensure we're not even attempting fast bindings for other
types. It also reduces overall binding overhead in that case by
moving direct indy logic out of the fail path and moves a couple
more adapted method handles to constants.

Fixes #5938.

This primarily adds a hard RubyFixnum or RubyFloat type check on
self, to ensure we're not even attempting fast bindings for other
types. It also reduces overall binding overhead in that case by
moving direct indy logic out of the fail path and moves a couple
more adapted method handles to constants.

Fixes jruby#5938.
@headius headius added this to the JRuby 9.2.9.0 milestone Oct 23, 2019
@kares
Copy link
Member

kares commented Oct 23, 2019

👍 this should resolve the issue.
got confused a bit since I expected a check on the indy path (before) reaching math-linker ...
as for non-indy self instanceof RubyFixnum/RubyFloat is done before reaching this logic.

@kares kares merged commit 11d5e74 into jruby:master Oct 24, 2019
kares added a commit to kares/jruby that referenced this pull request Oct 25, 2019
this seems to have gone unnoticed at jrubyGH-5939
also avoid warnings on == null condition being always true
kares added a commit that referenced this pull request Oct 25, 2019
this seems to have gone unnoticed at GH-5939
also avoid warnings on == null condition being always true
@headius headius deleted the restructure_indy_math branch October 27, 2019 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

regressed indy fixnum op with custom equality (==)
3 participants