Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix 'jruby: line 88: cd: ../libexec/bin: No such file …' #5977

Merged
merged 1 commit into from Dec 4, 2019

Conversation

pythias
Copy link
Contributor

@pythias pythias commented Nov 22, 2019

MacOS

brew install jruby
jruby -v
/usr/local/bin/jruby: line 88: cd: /usr/local/bin/jruby: Not a directory
Error: --module-path requires module path specification

@headius
Copy link
Member

@headius headius commented Dec 2, 2019

Request review from @mrnoname1000.

@headius headius added this to the JRuby 9.2.10.0 milestone Dec 2, 2019
@mrnoname1000
Copy link
Contributor

@mrnoname1000 mrnoname1000 commented Dec 3, 2019

Some testing shows incorrect paths in the original logic due to some weird issues with symlinked directories. I think the cd to BASE_DIR in the loop was a typo, and this fixes that. Looks good to me.

@headius
Copy link
Member

@headius headius commented Dec 4, 2019

@mrnoname1000 Thanks!

@headius headius merged commit 0a41f53 into jruby:master Dec 4, 2019
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants