Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not alias a Java IsEqual to equal? #6000

Merged
merged 1 commit into from Dec 12, 2019
Merged

Conversation

headius
Copy link
Member

@headius headius commented Dec 12, 2019

The equal? method should always be identity equality and not get overridden if a class defines an isEqual method as in Joda's AbstractPartial does.

Fixes #5990.

@headius headius added this to the JRuby 9.2.10.0 milestone Dec 12, 2019
@headius headius merged commit 50477d9 into jruby:master Dec 12, 2019
5 checks passed
@headius headius deleted the no_override_equal branch Dec 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant