Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check arity earlier in JavaConstructor#new_instance #6091

Merged
merged 1 commit into from Feb 23, 2020

Conversation

headius
Copy link
Member

@headius headius commented Feb 21, 2020

If this call were made with the wrong number of arguments, it could easily walk off the type array due to the lack of arity checking in the convertArguments call.

Fixes #6079.

@headius headius added this to the JRuby 9.2.11.0 milestone Feb 21, 2020
@headius headius changed the base branch from master to jruby-9.2 Feb 21, 2020
If this call were made with the wrong number of arguments, it
could easily walk off the type array due to the lack of arity
checking in the convertArguments call.

Fixes jruby#6079.
@headius
Copy link
Member Author

@headius headius commented Feb 21, 2020

Rebased to 9.2 for release.

@headius headius merged commit 2bd14b9 into jruby:jruby-9.2 Feb 23, 2020
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant