Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CGI.escapeHTML restore the original encoding #6097

Merged
merged 1 commit into from Mar 2, 2020
Merged

Conversation

ahorek
Copy link
Contributor

@ahorek ahorek commented Feb 25, 2020

fixes #6093

@headius
Copy link
Member

@headius headius commented Mar 2, 2020

@enebo Perhaps this is safe for 9.2.11?

@enebo enebo merged commit 7a05219 into jruby:master Mar 2, 2020
5 checks passed
@enebo enebo added this to the JRuby 9.2.11.0 milestone Mar 2, 2020
@enebo
Copy link
Member

@enebo enebo commented Mar 2, 2020

Fixes something I know which happens in web apps (bogus encoded text being source from users). Landing this seems like a net loss in new user reports from this behavioral difference with MRI. Seems reasonably safe too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants