Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruby 2.0 caller API #613

Closed
wants to merge 4 commits into from

Conversation

Projects
None yet
3 participants
@berdario
Copy link
Contributor

berdario commented Mar 28, 2013

#569

I'm not sure how to test this... it seems there're no unit test for caller in org.jruby.test.TestKernel and the rubyspec doesn't implement 2.0 semantics, at least for this method

berdario added some commits Mar 28, 2013

@berdario berdario closed this Mar 28, 2013

@berdario berdario reopened this Mar 28, 2013

@BanzaiMan

This comment has been minimized.

Copy link
Member

BanzaiMan commented Mar 29, 2013

If this is only for Ruby 2.0, compatibility version needs to be considered. As written, the behavior also manifests in 1.8 and 1.9 modes.

@headius

This comment has been minimized.

Copy link
Member

headius commented Mar 29, 2013

I've got this. Making tweaks so it only affects 2.0 mode and passes tests. Thanks for the PR!

@headius

This comment has been minimized.

Copy link
Member

headius commented Mar 29, 2013

Merged as of 1fe9081 (with tweaks).

@headius headius closed this Mar 29, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.