Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subtract begin offset for partial substring in sprintf 's' #6138

Merged
merged 3 commits into from Mar 25, 2020

Conversation

headius
Copy link
Member

@headius headius commented Mar 24, 2020

See #6137 for the original bug report. This PR includes the change proposed there along with some new doco for nth and a spec.

headius added 3 commits Mar 24, 2020
This gets a bit deep into how string buffers are used and shared
but since it was exposed as a bug (jruby#6137) and CRuby
does the same copy-on-write buffer treatment that JRuby does, it
seemed an appropriate spec to add.
@headius headius added this to the 9.2.11.1 milestone Mar 24, 2020
@headius headius changed the base branch from master to jruby-9.2 Mar 24, 2020
@headius headius requested a review from kares Mar 24, 2020
@headius headius merged commit bf8c2f4 into jruby:jruby-9.2 Mar 25, 2020
3 of 5 checks passed
@headius headius deleted the fix_6137 branch Mar 25, 2020
@headius
Copy link
Member Author

@headius headius commented Mar 25, 2020

Moving forward with this since we want to put a release out tomorrow.

@enebo enebo removed this from the 9.2.11.1 milestone Mar 25, 2020
@enebo enebo added this to the JRuby 9.2.11.1 milestone Mar 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants