New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Source FFI Ruby sources from the gem #6150
Conversation
f5fdaaf
to
9798741
Compare
I've rebased off current master and this should be ready to go now. We still have to update specs manually. |
So close! The main ffi.rb file unfortunately uses I have pushed ffi/ffi#823 to fix this and avoid touching the Gem namespace while loading ffi.rb. |
ffi/ffi#823 is merged and released as ffi-1.14.0. I also added JRuby tests on github actions, but they fail since this PR is not yet on jruby-head. |
@larskanis Thank you for the update! I will fix this to the release and merge. |
9798741
to
9cb31f1
Compare
This does not include the platform-specific constants files that appear to only live in JRuby's copy, probably from the original copy from Rubinius. They are needed for at least syslog and likely other FFI-based features in the standard library.
9cb31f1
to
862ebf4
Compare
@larskanis I am in the process of working out the last kinks, but noticed that there are platform files only in JRuby for things like syslog constants. I believe these files were generated by Rubinius many years ago and came along with us adding FFI to JRuby. Some of them even have Rubinius property names. I am fine keeping these files versioned in JRuby for now but I will be looking into a way to remove them from the |
A quick search seems to indicate that only the syslog files are being used by any libraries in JRuby. The |
@larskanis I have created #6503 to address the files not found in the FFI gem. |
This PR will remove FFI Ruby sources from our repository and source them from the gem, so they can be upgraded as any other default gem.
It doesn't pass now because the "java" version of the gem contains no sources.