Java classes with signatures should be reified #623

Merged
merged 4 commits into from May 21, 2013

Projects

None yet

3 participants

@daicoden
Contributor
daicoden commented Apr 2, 2013

It's possible that this actually isn't broken and I'm using the API improperly. I had to put the following change into a patch to use a java_signature that took a parameter.

Let me know!

@BanzaiMan BanzaiMan commented on an outdated diff Apr 2, 2013
docs/README.test
@@ -44,3 +44,9 @@ A slightly shorter run we run frequently is:
ant spec-short
The rubyspecs will be fetched over the net, and then executed.
+
+To run an individual test use the checked in bin/rspec executable
@BanzaiMan
BanzaiMan Apr 2, 2013 Member

This is incorrect. bin/rspec will be generated when rspec gem is installed by install-dev-gems ant target.

@BanzaiMan
Member

Hello. I updated the summary to reflect the intention of the pull request more accurately.

@headius headius was assigned Apr 2, 2013
@daicoden
Contributor
daicoden commented Apr 2, 2013

Thanks BanzaiMan, fixed!

@headius
Member
headius commented May 21, 2013

Looks good, merging!

@headius headius merged commit d4e50ba into jruby:master May 21, 2013

1 check passed

default The Travis build passed
Details
@headius
Member
headius commented May 21, 2013

FYI, I updated the readme to a more direct ant target for compiling tests: ant compile-test

@daicoden daicoden deleted the daicoden:java-signature-with-parameters branch Oct 7, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment