Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java classes with signatures should be reified #623

Merged
merged 4 commits into from May 21, 2013

Conversation

@daicoden
Copy link
Contributor

@daicoden daicoden commented Apr 2, 2013

It's possible that this actually isn't broken and I'm using the API improperly. I had to put the following change into a patch to use a java_signature that took a parameter.

Let me know!

@@ -44,3 +44,9 @@ A slightly shorter run we run frequently is:
ant spec-short

The rubyspecs will be fetched over the net, and then executed.

To run an individual test use the checked in bin/rspec executable

This comment has been minimized.

@BanzaiMan

BanzaiMan Apr 2, 2013
Member

This is incorrect. bin/rspec will be generated when rspec gem is installed by install-dev-gems ant target.

@BanzaiMan
Copy link
Member

@BanzaiMan BanzaiMan commented Apr 2, 2013

Hello. I updated the summary to reflect the intention of the pull request more accurately.

@ghost ghost assigned headius Apr 2, 2013
@daicoden
Copy link
Contributor Author

@daicoden daicoden commented Apr 2, 2013

Thanks BanzaiMan, fixed!

@headius
Copy link
Member

@headius headius commented May 21, 2013

Looks good, merging!

headius added a commit that referenced this pull request May 21, 2013
Java classes with signatures should be reified
@headius headius merged commit d4e50ba into jruby:master May 21, 2013
1 check passed
1 check passed
@enebo
default The Travis build passed
Details
@headius
Copy link
Member

@headius headius commented May 21, 2013

FYI, I updated the readme to a more direct ant target for compiling tests: ant compile-test

@daicoden daicoden deleted the daicoden:java-signature-with-parameters branch Oct 7, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants