Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not bind methods from classes that are not exported #6298

Merged
merged 1 commit into from Jun 25, 2020

Conversation

headius
Copy link
Member

@headius headius commented Jun 25, 2020

This cherry-picks the fix for #6287 for 9.2.12.

Similar to non-public classes, we don't want to bind the
reflected methods from no-exported classes, since dispatching to
those method objects will fail with an IllegalAccessException. We
avoid setting up methods on those proxies and allow public
supertypes to provide them.

Fixes jruby#6287
@headius headius added this to the JRuby 9.2.12.0 milestone Jun 25, 2020
@headius headius changed the base branch from master to jruby-9.2 Jun 25, 2020
@headius
Copy link
Member Author

headius commented Jun 25, 2020

Something strange is up with the Travis failures unrelated to this PR. It seems to be picking up a filename from master even though the only commit makes no such change. Will merge and see if it happens on the branch.

@headius headius merged commit 03dea6f into jruby:jruby-9.2 Jun 25, 2020
1 check failed
@headius headius deleted the non_exported_9.2 branch Jun 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant