Implemented OpenSSL::PKCS7::write_smime #634

Merged
merged 1 commit into from Apr 16, 2013

Projects

None yet

4 participants

@anoopsankar
Contributor

The implementation follows the C openssl source as much as possible.

Have also made some minor changes to keep compatibility with the MRI implementation.

@nahi nahi was assigned Apr 13, 2013
@BanzaiMan
Member

We'll still need an expert opinion, but in the meantime, could you remove TRAVIS_PUSH and squash the commits into one?

Thanks.

@anoopsankar
Contributor

@BanzaiMan Have done the same. Sorry for the mess up :)

Thanks.

@BanzaiMan
Member

@nahi Could you take a look?

@headius
Member
headius commented Apr 16, 2013

There do not appear to be any tests for write_smime. Bummer.

I filed this: https://bugs.ruby-lang.org/issues/8274

@headius
Member
headius commented Apr 16, 2013

I'm going to proactively merge this; probably-working is better than definitely broken, right?

@headius headius merged commit 289d80d into jruby:master Apr 16, 2013

1 check passed

default The Travis build passed
Details
@anoopsankar
Contributor

@headius I'm in the process of writing some integration tests. I'll push that as a new pull request?

(EDIT: Tests as in test cases in test/test_openssl.rb within the jruby project.)

@headius
Member
headius commented Apr 16, 2013

Ideally you should submit them as a pull request against ruby/ruby, and cc me so I can get them included (I am a committer). We copy our tests -- modulo a few diffs -- directly from MRI. Once I've added your tests to MRI (trunk) I'll add them to our diffs (1.9.3).

Also comment on the bug I filed against MRI, once you have tests...so we are following process.

@anoopsankar
Contributor

Ok great. Will do. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment