The implementation follows the C openssl source as much as possible.
Have also made some minor changes to keep compatibility with the MRI implementation.
We'll still need an expert opinion, but in the meantime, could you remove TRAVIS_PUSH and squash the commits into one?
Implemented write_smime() for OpenSSL::PKCS7.
@BanzaiMan Have done the same. Sorry for the mess up :)
@nahi Could you take a look?
There do not appear to be any tests for write_smime. Bummer.
I filed this: https://bugs.ruby-lang.org/issues/8274
I'm going to proactively merge this; probably-working is better than definitely broken, right?
@headius I'm in the process of writing some integration tests. I'll push that as a new pull request?
(EDIT: Tests as in test cases in test/test_openssl.rb within the jruby project.)
Ideally you should submit them as a pull request against ruby/ruby, and cc me so I can get them included (I am a committer). We copy our tests -- modulo a few diffs -- directly from MRI. Once I've added your tests to MRI (trunk) I'll add them to our diffs (1.9.3).
Also comment on the bug I filed against MRI, once you have tests...so we are following process.
Ok great. Will do. Thanks!