Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented OpenSSL::PKCS7::write_smime #634

Merged
merged 1 commit into from Apr 16, 2013

Conversation

Projects
None yet
4 participants
@anoopsankar
Copy link
Contributor

anoopsankar commented Apr 12, 2013

The implementation follows the C openssl source as much as possible.

Have also made some minor changes to keep compatibility with the MRI implementation.

@ghost ghost assigned nahi Apr 13, 2013

@BanzaiMan

This comment has been minimized.

Copy link
Member

BanzaiMan commented Apr 13, 2013

We'll still need an expert opinion, but in the meantime, could you remove TRAVIS_PUSH and squash the commits into one?

Thanks.

@anoopsankar

This comment has been minimized.

Copy link
Contributor Author

anoopsankar commented Apr 13, 2013

@BanzaiMan Have done the same. Sorry for the mess up :)

Thanks.

@BanzaiMan

This comment has been minimized.

Copy link
Member

BanzaiMan commented Apr 14, 2013

@nahi Could you take a look?

@headius

This comment has been minimized.

Copy link
Member

headius commented Apr 16, 2013

There do not appear to be any tests for write_smime. Bummer.

I filed this: https://bugs.ruby-lang.org/issues/8274

@headius

This comment has been minimized.

Copy link
Member

headius commented Apr 16, 2013

I'm going to proactively merge this; probably-working is better than definitely broken, right?

headius added a commit that referenced this pull request Apr 16, 2013

Merge pull request #634 from anoopsankar/master
Implemented OpenSSL::PKCS7::write_smime

@headius headius merged commit 289d80d into jruby:master Apr 16, 2013

1 check passed

default The Travis build passed
Details
@anoopsankar

This comment has been minimized.

Copy link
Contributor Author

anoopsankar commented Apr 16, 2013

@headius I'm in the process of writing some integration tests. I'll push that as a new pull request?

(EDIT: Tests as in test cases in test/test_openssl.rb within the jruby project.)

@headius

This comment has been minimized.

Copy link
Member

headius commented Apr 16, 2013

Ideally you should submit them as a pull request against ruby/ruby, and cc me so I can get them included (I am a committer). We copy our tests -- modulo a few diffs -- directly from MRI. Once I've added your tests to MRI (trunk) I'll add them to our diffs (1.9.3).

Also comment on the bug I filed against MRI, once you have tests...so we are following process.

@anoopsankar

This comment has been minimized.

Copy link
Contributor Author

anoopsankar commented Apr 16, 2013

Ok great. Will do. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.