Skip to content

Loading…

remove double assignment and addition to 0 #635

Closed
wants to merge 1 commit into from

2 participants

@vipulnsward

remove double assignment and addition to 0

@BanzaiMan
JRuby Team member

These should be two separate commits, since they are two completely separate ideas.

Furthermore, for the MurmurHash commit, one may argue that it adds symmetry to the code. What do you think?

@vipulnsward

Updating to remove second change for now.

@ghost

Merged double assignment removal in commit 0012c9c

I agree with @BanzaiMan - the + 0 style is usually done to be symmetric (even though most IDEs and code checker tools will flag it for removal).

@ghost ghost closed this
@vipulnsward vipulnsward deleted the vipulnsward:some_code_cleanup branch
@vipulnsward

@wmeissner I thought that the above class must be used a lot,so proposed the change.removed after seeing it was used less.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Apr 14, 2013
  1. @vipulnsward

    remove double assignment

    vipulnsward committed
Showing with 1 addition and 1 deletion.
  1. +1 −1 src/org/jruby/RubyInstanceConfig.java
View
2 src/org/jruby/RubyInstanceConfig.java
@@ -1678,7 +1678,7 @@ public boolean shouldPrecompileAll() {
////////////////////////////////////////////////////////////////////////////
private static int initGlobalJavaVersion() {
- String specVersion = specVersion = Options.BYTECODE_VERSION.load();
+ String specVersion = Options.BYTECODE_VERSION.load();
// stack map calculation is failing for some compilation scenarios, so
// forcing both 1.5 and 1.6 to use 1.5 bytecode for the moment.
Something went wrong with that request. Please try again.