Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove double assignment and addition to 0 #635

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
2 participants
@vipulnsward
Copy link
Contributor

vipulnsward commented Apr 13, 2013

remove double assignment and addition to 0

@BanzaiMan

This comment has been minimized.

Copy link
Member

BanzaiMan commented Apr 14, 2013

These should be two separate commits, since they are two completely separate ideas.

Furthermore, for the MurmurHash commit, one may argue that it adds symmetry to the code. What do you think?

@vipulnsward

This comment has been minimized.

Copy link
Contributor Author

vipulnsward commented Apr 14, 2013

Updating to remove second change for now.

@ghost

This comment has been minimized.

Copy link

ghost commented Apr 14, 2013

Merged double assignment removal in commit 0012c9c

I agree with @BanzaiMan - the + 0 style is usually done to be symmetric (even though most IDEs and code checker tools will flag it for removal).

@ghost ghost closed this Apr 14, 2013

@vipulnsward vipulnsward deleted the vipulnsward:some_code_cleanup branch Apr 14, 2013

@vipulnsward

This comment has been minimized.

Copy link
Contributor Author

vipulnsward commented Apr 14, 2013

@wmeissner I thought that the above class must be used a lot,so proposed the change.removed after seeing it was used less.

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.