Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Date/DateTime loosing offset on marshal #6424

merged 1 commit into from Oct 6, 2020


Copy link

@kares kares commented Oct 4, 2020

This is a regression since Date/DateTime where moved to native in 9.2.
In JRuby 9.1 we used to store the offset as it's returned by Date#offset (usually a Rational),
however on the native side we now store * DAYS_IN_SECONDS an an integer.

The change here restores 9.1 behaviour.

resolves GH-6385

@kares kares added this to the JRuby milestone Oct 4, 2020
@kares kares linked an issue Oct 4, 2020 that may be closed by this pull request
Copy link

@headius headius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love a good one-liner. 👍

@headius headius merged commit b9d2c1e into jruby:jruby-9.2 Oct 6, 2020
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

DateTime loses timezone offsets on marshal/unmarshal
2 participants