Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIXES #235 Fix for relative require from within a gem on the classpath. #643

Merged
merged 1 commit into from Apr 16, 2013

Conversation

Projects
None yet
2 participants
@akiellor
Copy link
Contributor

akiellor commented Apr 16, 2013

FIXES #235

The test for this bug is an acceptance test, I feel like testing this particular behaviour would be better as a unit test for the LoadService (or NormalSearcher), but the visibility on the internals of the LoadService make this difficult to unit test.

Should we be doing work to factor the LoadService for unit testability?

@headius

This comment has been minimized.

Copy link
Member

headius commented Apr 16, 2013

I'd love to be able to do better testing of JRuby internals, and refactoring could certainly help. We do have a JUnit-based test for LoadService you might look at editing.

I'll review your change.

@headius

This comment has been minimized.

Copy link
Member

headius commented Apr 16, 2013

The change looks pretty clean. I hate the fact that JVM mixes "jar:" and "jar:file:" URLs unpredictably, but this seems like a reasonable fix. Merging.

headius added a commit that referenced this pull request Apr 16, 2013

Merge pull request #643 from akiellor/relative-require-in-rubygem
FIXES #235 Fix for relative require from within a gem on the classpath.

@headius headius merged commit 1f6d3dc into jruby:master Apr 16, 2013

1 check was pending

default The Travis build is in progress
Details

@akiellor akiellor deleted the akiellor:relative-require-in-rubygem branch Apr 16, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.