Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timezone fixes for 2.6 logic #6494

merged 1 commit into from Dec 15, 2020

Timezone fixes for 2.6 logic #6494

merged 1 commit into from Dec 15, 2020


Copy link

@headius headius commented Dec 15, 2020

This contains one or more fixes for timezone handling in 2.6 compatibility.

See #6488, which these fixes are intended to resolve.

This method should extract the equivalent ms from the time without
considering timezone, so the absolute value can be subtracted from
a time with a timezone to get the zone offset. Joda normalizes
getMillis to universal time, causing the resulting offset to be

The patch here forces the Joda DateTime to UTC without altering
the other time fields, allowing us to get equivalent UTC millis
for the given time.

Fixes jruby#6488
@headius headius added this to the JRuby milestone Dec 15, 2020
@headius headius merged commit af0582d into jruby:master Dec 15, 2020
@headius headius deleted the tz26_fixes branch December 15, 2020 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

1 participant