Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small spawn fixes #6498

merged 9 commits into from Dec 17, 2020

Small spawn fixes #6498

merged 9 commits into from Dec 17, 2020


Copy link

@headius headius commented Dec 16, 2020

Various fixes to try to tidy up tests and specs we are not currently passing.

@headius headius added this to the JRuby milestone Dec 16, 2020
This was disabled because we can't close them in the parent, but
posix_spawn provides a way to close during the fork. This code was
active but not reachable.
Most of this will never be possible with posix_spawn so having the
commented code from CRuby is not useful.
Now uses posix_spawn rather than opening file in parent process,
and properly uses WRONLY when redirecting out and err.
@headius headius merged commit 9d224a7 into jruby:master Dec 17, 2020
@headius headius deleted the spawn_stuff branch December 17, 2020 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

1 participant