Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[socket] improve keep alive support #6542

merged 1 commit into from Jan 29, 2021

[socket] improve keep alive support #6542

merged 1 commit into from Jan 29, 2021


Copy link

@ahorek ahorek commented Jan 28, 2021

this PR improves Redis support for their TCP keep-alive implementation #6541

also fixes a bug, getsockopt returns zero if the passed constant isn't supported. It should always be a SocketOption or an exception.

@ahorek ahorek changed the title WIP: [socket] improve keep alive support [socket] improve keep alive support Jan 28, 2021
Copy link

@headius headius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@headius headius added this to the JRuby milestone Jan 29, 2021
@headius headius merged commit 7b9f596 into jruby:master Jan 29, 2021
MariuszCwikla pushed a commit to MariuszCwikla/jruby that referenced this pull request Feb 4, 2021
@headius headius modified the milestones: JRuby, JRuby Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants