Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #645 by calling Java Math.cbrt directly. #656

Merged
merged 1 commit into from Apr 25, 2013

Conversation

Projects
None yet
3 participants
@tychobrailleur
Copy link
Contributor

tychobrailleur commented Apr 25, 2013

This fixed #645 by calling java.lang.Math.cbrt directly. Math.cbrt was introduced in Java 5, so it is safe to use in the JRuby codebase. Also, cbrt now throws a TypeError if the argument cannot be coerced to Float.

Related rubyspec change: https://github.com/rubyspec/rubyspec/pull/206

headius added a commit that referenced this pull request Apr 25, 2013

Merge pull request #656 from tychobrailleur/cbrt
Fix #645 by calling Java Math.cbrt directly.

@headius headius merged commit 62b9e1d into jruby:master Apr 25, 2013

1 check passed

default The Travis build passed
Details
@d1egoaz

This comment has been minimized.

Copy link

d1egoaz commented Apr 25, 2013

Tks so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.