Backport spawn fixes to 9.2 #6568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change helps make our sh-based chdir work properly without us mashing the command + arguments together into a string that may parse badly when passed to sh -c. The primary trick here is to use sh to do the chdir followed by an exec of the explicit argument list passed in. The chdir will run in the intermediate shell, as with a fork/exec, and then the exec will receive the actual target program and its arguments unpolluted. With this change, the example from jruby#6153 works properly, and the Ruby script is passed along without sh seeing it as part of a shell script.
* Avoid having user values in $0 for sh. * Use -- to terminate chdir argument list.
We'll do a CRuby exclude sweep soon.
This uncomments some paths that are not yet used but will be once Windows support comes along.
This allows platform, "travis", and "hangs" tags.
Tainting is deprecated and was never reliable as a security mechanism.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR backports the spawn-related cleanup and fixes to 9.2 from #6226.
See also #6565.