[refactor] move include_package into Java #6661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kares
force-pushed
the
java-include
branch
2 times, most recently
from
378a3dc
to
cc21824
Compare
mostly following up with the `java_import` part
since a failure with (Integer) const re-assignment has potential consequences for the whole suite
|
This looks good to me. Remove the commented-out load of module.rb when you decide you are done with it. |
|
WIndows failure is #6678, disregard. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also
java_importwas moved to not have these in 2 places (could ditch the whole JI module.rb ext file)the motivation for the move is to have predictable include_package behavior e.g. on Java linking errors.
previously w
include_package, allNameErrorwhere rescued and loop continued attempting to load a class with the next package -> effectively creating a weird set of errors where the real cause is unknown e.g. cheald/manticore#87the changes here make sure only
ClassNotFoundExceptionis a valid error to continue the loop, alll otherNameErrorinstances (e.g. caused byLinkageError) will be raised promptly.