Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix float rounding issues. #668

Merged
merged 1 commit into from Apr 28, 2013

Conversation

Projects
None yet
2 participants
@tychobrailleur
Copy link
Contributor

commented Apr 28, 2013

This pull request fixes the 6 failing rubyspecs in core/float/round_spec.rb.

The Double → String → BigDecimal → BigInteger conversion is probably not optimal from a perf perspective, but AFAICT it’s the only to get the correct precision when converting from double to BigInteger.

headius added a commit that referenced this pull request Apr 28, 2013

@headius headius merged commit baa048a into jruby:master Apr 28, 2013

1 check passed

default The Travis build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.