Fixes #6692. AIOOBE on evals overflowing closure ids. #6704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has two pieces: 1. Evals only live as a scope as long as they execute. They should not be asking the lexical scope they are called in for an id. This is likely a portion (or all) of the original reporters problem. 2. Closures in evals should be given out scope ids relative to the eval. These were going to the eval and then the evals getScopeID would ask its lexical parent for an ID (which is the scope outside the eval).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has two pieces:
Evals only live as a scope as long as they execute. They should not
be asking the lexical scope they are called in for an id. This is likely
a portion (or all) of the original reporters problem.
Closures in evals should be given out scope ids relative to the eval.
These were going to the eval and then the evals getScopeID would ask its
lexical parent for an ID (which is the scope outside the eval).