Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
My stab at fixing JRUBY-7122 #674
We could probably expand this to also include jar: and jar-based file: URL forms, so we don't have to patch it in the future. Want to give that a shot?
I think the possible forms are:
As I wrote this, it occurred to me that both of those cases will still need realpath logic for since there could be symlinks...so maybe that should be a separate issue/PR.
Anyway, I'll merge in your fix, since it's definitely correct for classpath: entries.
I added some specs to my fork for this, but the jar:file: ones fail.
JRubyFile.create is being used to do the relativisation logic. JRubyFile did appear to work for classpath: on this computer (not Windows), but it was giving the wrong result on Windows. Give it a jar:file: path though, and it just explodes because the file doesn't exist.
So either JRubyFile.create would have to be fixed to support non-file-paths or I'd want another utility to do the double-dot removals for me which worked for non-existent paths as well as existing paths.
Then the idea would be to rewrite the method to use the following steps:
Something else really odd I'm finding. If I try to build up a path to a jar:file URL where I specify the absolute path, I get an error about the file not existing. If I try to build it up as a relative path from a jar:file URL, that works fine. I don't get why one would work and the other wouldn't.
I improved my fork to pass two more specs and added one more spec - the symlink thing still doesn't work but I'm not entirely sure where the symlink stuff is being done, so it could be an invalid test case.
Also at least one of the tests probably fails on Windows, but I won't know until tomorrow.
Finding another user here having issues with require_relative. I'm sure this is probably tied into the same mess. I initially couldn't figure out what was different from my path but then I noticed his path...
I bet it's that %20... yet another edge case I didn't expect.