Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing rubyspecs for String#unpack #675

Merged
merged 4 commits into from Apr 29, 2013

Conversation

Projects
None yet
2 participants
@tychobrailleur
Copy link
Contributor

tychobrailleur commented Apr 29, 2013

This fixes the 22 failing specs for String#unpack, and addresses http://jira.codehaus.org/browse/JRUBY-5656.

@tychobrailleur

This comment has been minimized.

Copy link
Contributor Author

tychobrailleur commented Apr 29, 2013

Hmm, odd one: the build fails, but all I can see is an error whilst building jruby-launcher which doesn’t sound related?

@headius

This comment has been minimized.

Copy link
Member

headius commented Apr 29, 2013

Yeah, I think the build's failure has nothing to do with your changes. I'll review what you have here and make sure it's working ok before pushing.

@headius

This comment has been minimized.

Copy link
Member

headius commented Apr 29, 2013

Looks ok here!

headius added a commit that referenced this pull request Apr 29, 2013

Merge pull request #675 from tychobrailleur/string_unpack
Fix failing rubyspecs for String#unpack

@headius headius merged commit f6a9649 into jruby:master Apr 29, 2013

1 check failed

default The Travis build failed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.