Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unseekable stream implementation of IO.copy_stream in RubyIO.java #683

Merged
merged 1 commit into from May 1, 2013

Conversation

Projects
None yet
2 participants
@pfoorion
Copy link
Contributor

pfoorion commented Apr 30, 2013

Fixes JRUBY-7157
Fixed the transfer method to properly handle the fact that Java's FileChannel transferFrom method doesn't update the position of the destination channel. This version of the transfer method is only called if the source stream is unseekable (i.e. a socket or, in my case ServletUpload's FileItemStream). The bug occurs if the size of the source is greater than 4196 bytes.

@headius

This comment has been minimized.

Copy link
Member

headius commented May 1, 2013

Looks good, thanks!

headius added a commit that referenced this pull request May 1, 2013

Merge pull request #683 from pfoorion/master
Fix unseekable stream implementation of IO.copy_stream in RubyIO.java

@headius headius merged commit 2379957 into jruby:master May 1, 2013

1 check failed

default The Travis build failed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.