Fix unseekable stream implementation of IO.copy_stream in #683

merged 1 commit into from May 1, 2013


None yet

2 participants


Fixes JRUBY-7157
Fixed the transfer method to properly handle the fact that Java's FileChannel transferFrom method doesn't update the position of the destination channel. This version of the transfer method is only called if the source stream is unseekable (i.e. a socket or, in my case ServletUpload's FileItemStream). The bug occurs if the size of the source is greater than 4196 bytes.

headius commented May 1, 2013

Looks good, thanks!

@headius headius merged commit 2379957 into jruby:master May 1, 2013

1 check failed

default The Travis build failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment