Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time methods should coerce the day, hour, minute, or second with #to_int #687

Merged
merged 1 commit into from May 1, 2013

Conversation

Projects
None yet
2 participants
@atambo
Copy link
Member

atambo commented May 1, 2013

No description provided.

@atambo

This comment has been minimized.

Copy link
Member Author

atambo commented May 1, 2013

I ran rake test:mri19 locally and it passed for me. Is there a way for me to trigger the travis build?

@headius

This comment has been minimized.

Copy link
Member

headius commented May 1, 2013

Since it only failed one platform, I would guess this may be a bad test that has a timing dependency. I've requested travis to re-run the build, so we'll see how it looks.

@headius

This comment has been minimized.

Copy link
Member

headius commented May 1, 2013

Looks good now! Damn those bad tests :-)

I'll merge.

headius added a commit that referenced this pull request May 1, 2013

Merge pull request #687 from atambo/time_coerce_to_int
Time methods should coerce the day, hour, minute, or second with #to_int

@headius headius merged commit cfa3dc4 into jruby:master May 1, 2013

1 check passed

default The Travis build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.