Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rubygems to 3.2.29 and bundler to 2.2.29 #6890

Merged
merged 1 commit into from Oct 13, 2021
Merged

Conversation

jsvd
Copy link
Contributor

@jsvd jsvd commented Oct 12, 2021

In March 2021 PR #6533 added support for RubyGems to 3.2 and Bundler 2.2 but pinned the versions that were released at the time.
This PR was merged into the 9.3.0.0, but this jruby release only happened in September, meaning that JRuby 9.3.0.0 ships with older versions of bundler compared even to JRuby 9.2.

In March 2021 PR jruby#6533 added support for RubyGems to 3.2 and Bundler 2.2 but pinned the versions that were released at the time.
This PR was merged into the 9.3.0.0, but this jruby release only happened in September, meaning that JRuby 9.3.0.0 ships with older versions of bundler compared even to JRuby 9.2.
@kares
Copy link
Member

kares commented Oct 13, 2021

JRuby 9.3.0.0 claims Ruby 2.6.8 compatibility,
interestingly the out-of-the box experience downloading from ruby-lang.org: https://www.ruby-lang.org/en/news/2021/07/07/ruby-2-6-8-released/

... one gets Bundler 1.17.2 and RubyGems 3.0.3.1 in the dist.
Guess everyone has a favorite Ruby version manager/installed which take care of shipping up-to-date RGs + Bundler.

anyhow I think the PR is legit (patch updates only).
NOTE: bundler + rubygems-update releases are now aligned on patch releases (thus the same .29 version).

@kares kares added this to the JRuby 9.3.1.0 milestone Oct 13, 2021
@enebo enebo merged commit 45a0ea5 into jruby:master Oct 13, 2021
@ThomasKoppensteiner
Copy link

FYI: Bundler was set to 2.2.29 not to 3.2.29.

@jsvd jsvd changed the title Update rubygems to 2.2.29 and bundler to 3.2.29 Update rubygems to 3.2.29 and bundler to 2.2.29 Oct 14, 2021
@jsvd
Copy link
Contributor Author

jsvd commented Oct 14, 2021

derp, I fixed the issue title, too late for the commit message, well spotted.

@jsvd jsvd deleted the patch-1 branch October 14, 2021 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants