Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regexp#options should include FIXEDENCODING and NOENCODING when enabled #695

Merged
merged 1 commit into from May 4, 2013

Conversation

Projects
None yet
2 participants
@atambo
Copy link
Member

atambo commented May 2, 2013

No description provided.

@headius

This comment has been minimized.

Copy link
Member

headius commented May 3, 2013

One of the failures appears to be memory (Travis sometimes glitches for us) but the other is related to options. Want to take a look at that?

@atambo

This comment has been minimized.

Copy link
Member Author

atambo commented May 3, 2013

I tweaked the commit and force pushed to this branch again but I don't see the travis build indicator thingy anymore. However, looks like travis is running here: https://travis-ci.org/jruby/jruby/builds/6838381

@atambo

This comment has been minimized.

Copy link
Member Author

atambo commented May 3, 2013

One passed and the other ran out of memory so I think this is fixed now.

headius added a commit that referenced this pull request May 4, 2013

Merge pull request #695 from atambo/regex_options_fixed_none
Regexp#options should include FIXEDENCODING and NOENCODING when enabled

@headius headius merged commit 6768039 into jruby:master May 4, 2013

1 check failed

default The Travis build failed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.