Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supporting IO.ungetbyte #697

Merged
merged 1 commit into from May 4, 2013

Conversation

Projects
None yet
2 participants
@josedonizetti
Copy link
Member

josedonizetti commented May 3, 2013

We can use ungetc to support ungetbyte, that will left only 1 spec failing which is an edge case. What happens is that when trying to push the number 4095, like the specs do on the ChanelStream class that int will be convert to a byte (-1) and inside jruby internals -1 is considered EOF, so for we to support this we would have to change a lot of things. The method willl work for every number but 4095 because of this case.

headius added a commit that referenced this pull request May 4, 2013

@headius headius merged commit 87605ef into jruby:master May 4, 2013

1 check failed

default The Travis build could not complete due to an error
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.