Fix string concatenation with a number as per rubyspec behaviour. #727

Merged
merged 1 commit into from May 21, 2013

Projects

None yet

2 participants

@tychobrailleur
Contributor

Following tychobrailleur/jcodings@8536b4f, the incorrect behaviour of String#concat with
a number was made obvious by throwing an EncodingException. MRI changes
the encoding of the String if the concatenated codepoint is within
ASCII-8BIT range, and throws a RangeError otherwise.

@tychobrailleur tychobrailleur Fix string concatenation with a number as per rubyspec behaviour.
Following tychobrailleur/jcodings@8536b4f, the incorrect behaviour of String#concat with
a number was made obvious by throwing an EncodingException.  MRI changes
the encoding of the String if the concatenated codepoint is within
ASCII-8BIT range, and throws a RangeError otherwise.
f4bd113
@headius headius merged commit ccd06ac into jruby:master May 21, 2013

1 check passed

default The Travis CI build passed
Details
@headius
Member
headius commented Jun 6, 2013

Please try to remember to set a milestone for closed issues :-)

@tychobrailleur
Contributor

@headius Oh, did I close that issue?

@tychobrailleur
Contributor

@headius Never mind, gotcha! (=

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment