Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix string concatenation with a number as per rubyspec behaviour. #727

Merged
merged 1 commit into from May 21, 2013

Conversation

@tychobrailleur
Copy link
Contributor

@tychobrailleur tychobrailleur commented May 11, 2013

Following tychobrailleur/jcodings@8536b4f, the incorrect behaviour of String#concat with
a number was made obvious by throwing an EncodingException. MRI changes
the encoding of the String if the concatenated codepoint is within
ASCII-8BIT range, and throws a RangeError otherwise.

Following tychobrailleur/jcodings@8536b4f, the incorrect behaviour of String#concat with
a number was made obvious by throwing an EncodingException.  MRI changes
the encoding of the String if the concatenated codepoint is within
ASCII-8BIT range, and throws a RangeError otherwise.
headius added a commit that referenced this issue May 21, 2013
Fix string concatenation with a number as per rubyspec behaviour.
@headius headius merged commit ccd06ac into jruby:master May 21, 2013
1 check passed
@headius
Copy link
Member

@headius headius commented Jun 6, 2013

Please try to remember to set a milestone for closed issues :-)

@tychobrailleur
Copy link
Contributor Author

@tychobrailleur tychobrailleur commented Jun 6, 2013

@headius Oh, did I close that issue?

@tychobrailleur
Copy link
Contributor Author

@tychobrailleur tychobrailleur commented Jun 6, 2013

@headius Never mind, gotcha! (=

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants