Fix RubyString#byteslice on substring. #734

Merged
merged 1 commit into from May 21, 2013

Projects

None yet

4 participants

@grddev
Contributor
grddev commented May 14, 2013

As value.getBegin() already managed by makeShared19(), the method
byteSubstr() need not take it into account.

@grddev grddev Fix RubyString#byteslice on substring.
As value.getBegin() already managed by makeShared19(), the method
byteSubstr() need not take it into account.
c7ed4ab
@headius
Member
headius commented May 21, 2013

Testing locally before merge.

@jrubyci jrubyci merged commit c7ed4ab into jruby:master May 21, 2013

1 check failed

default The Travis CI build failed
Details
@mrbrdo
Contributor
mrbrdo commented Jun 17, 2013

I'm running into this on 1.7.4 (I think it's triggered by Nokogiri), is there any way I could do anything to work around it until 1.7.5 is released? I.e. without compiling a custom build of JRuby. Would it be possible to monkey patch from within a ruby script?
I know particularly where this happens for me and it's only in one place, so I can catch the exception etc.
Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment