Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RubyString#byteslice on substring. #734

Merged
merged 1 commit into from May 21, 2013

Conversation

Projects
None yet
4 participants
@grddev
Copy link
Contributor

grddev commented May 14, 2013

As value.getBegin() already managed by makeShared19(), the method
byteSubstr() need not take it into account.

Fix RubyString#byteslice on substring.
As value.getBegin() already managed by makeShared19(), the method
byteSubstr() need not take it into account.
@headius

This comment has been minimized.

Copy link
Member

headius commented May 21, 2013

Testing locally before merge.

@jrubyci jrubyci merged commit c7ed4ab into jruby:master May 21, 2013

1 check failed

default The Travis CI build failed
Details
@mrbrdo

This comment has been minimized.

Copy link
Contributor

mrbrdo commented Jun 17, 2013

I'm running into this on 1.7.4 (I think it's triggered by Nokogiri), is there any way I could do anything to work around it until 1.7.5 is released? I.e. without compiling a custom build of JRuby. Would it be possible to monkey patch from within a ruby script?
I know particularly where this happens for me and it's only in one place, so I can catch the exception etc.
Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.