Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update OSGi classloader #741

merged 646 commits into from May 17, 2013

Update OSGi classloader #741

merged 646 commits into from May 17, 2013


Copy link

@ajuckel ajuckel commented May 16, 2013

I've added an OSGi integration test. Currently it needs to be run after ant jar-jruby-complete and you need to use either the felix2 or felix4 profile. I'm open to suggestions for how to better integrate the test case.

After adding the test case, I added a different method to find the classloader for a bundle. I added this as a set of new classes, mostly because I wanted to ensure any users of the existing classes wouldn't be affected.

I verified that the new method does fallback correctly in the felix2 profile (which doesn't export the new org.osgi.framework.wiring package.

enebo and others added 30 commits Apr 23, 2013
File/IO readlines supporting new params limit, and open mode (thanks jose!)
Restore $! when catching exception.  In most cases jnr-posix on an error will throw and not get caught like this.   This is a special case and without significant changes jnr-posix this looks like the best fix to me.
It seems that changed the CA cert it uses for its
ssl connection, and that caused us to start failing tests. After
some investigation, I figured out which cert we needed and what
the filename needed to be in the ca_path test. I have added a
README.txt to the ca_path and comments to all the related certs.
I also removed a cert file that appeared to be duplicate and added
a more explicitly incorrect cert for the test that is supposed to
fail verification.
This should fix jruby#653. We may catch too much here, but it seems
the intent of the rescue block was to capture most exceptions. It
also would have caught the ant ExitStatusException as a
NativeException before, but that stopped working after we stopped
wrapping Java exceptions. The fix should catch it properly now.
enebo and others added 27 commits May 10, 2013

IO.binwrite doesn't truncate the file if an offset is given
@jrubyci jrubyci merged commit e74c159 into jruby:master May 17, 2013
1 check failed
Copy link

@headius headius commented May 17, 2013

Wow, I don't know what happened there, but it's merged.


Copy link

@enebo enebo commented May 17, 2013



Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet