Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove a bad assert and untag some tests it was affecting #760

Merged
merged 2 commits into from May 24, 2013

Conversation

Projects
None yet
2 participants
@dmarcotte
Copy link
Contributor

dmarcotte commented May 24, 2013

Okay, here's the spiritual successor to the aborted #757. Travis is happy!

I tracked down the difference between local runs and Travis runs to assertions being enabled on Travis. A bad assert was making enemies of a bunch of working specs.

I've organized this pull into two commits to make it easier to read: the actual code change and the subsequent test untagging. Note that there may be specs outside of command_line and core/argf that are also brought back to life by this; I'll have a look soon.

dmarcotte added some commits May 24, 2013

Remove bad assert
Seems this assert was typoed, and was accidentally asserting the
nullness of something which is definitely not null.  This was causing
a number of false negatives when the tests were run with assertions
enabled.

Note that this commit completely removes the null checking since it
can't do any good: this code would NPE earlier if line was null.
Untag a batch of passing tests
These were failing on CI due to a bad assert.  Untag them now that the
offending assert is gone.  Note: there my be other tests which are
also clean now that the assert is gone.  Will check for them soon.

atambo added a commit that referenced this pull request May 24, 2013

Merge pull request #760 from dmarcotte/bad-assert
Remove a bad assert and untag some tests it was affecting

@atambo atambo merged commit e507516 into jruby:master May 24, 2013

1 check passed

default The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.