Remove a bad assert and untag some tests it was affecting #760

merged 2 commits into from May 24, 2013


None yet

2 participants


Okay, here's the spiritual successor to the aborted #757. Travis is happy!

I tracked down the difference between local runs and Travis runs to assertions being enabled on Travis. A bad assert was making enemies of a bunch of working specs.

I've organized this pull into two commits to make it easier to read: the actual code change and the subsequent test untagging. Note that there may be specs outside of command_line and core/argf that are also brought back to life by this; I'll have a look soon.

dmarcotte added some commits May 24, 2013
@dmarcotte dmarcotte Remove bad assert
Seems this assert was typoed, and was accidentally asserting the
nullness of something which is definitely not null.  This was causing
a number of false negatives when the tests were run with assertions

Note that this commit completely removes the null checking since it
can't do any good: this code would NPE earlier if line was null.
@dmarcotte dmarcotte Untag a batch of passing tests
These were failing on CI due to a bad assert.  Untag them now that the
offending assert is gone.  Note: there my be other tests which are
also clean now that the assert is gone.  Will check for them soon.
@atambo atambo merged commit e507516 into jruby:master May 24, 2013

1 check passed

default The Travis CI build passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment