Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

binwrite should pass write only when options are not empty but don't have a "mode" #763

Merged
merged 1 commit into from May 25, 2013

Conversation

@josedonizetti
Copy link
Member

@josedonizetti josedonizetti commented May 25, 2013

This fixes problem when passing "encoding" as an option but don't pass a "mode".
I added this spec to rubyspec on this commit:

https://github.com/rubyspec/rubyspec/commit/f32725141a63a621b771755dc50ec107db0324d6

atambo added a commit that referenced this pull request May 25, 2013
binwrite should pass write only when options are not empty but don't have a "mode"
@atambo atambo merged commit d64a28b into jruby:master May 25, 2013
1 check passed
1 check passed
@headius
default The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants