Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for options and not truncating offset for IO.write #764

Merged
merged 1 commit into from May 25, 2013

Conversation

@josedonizetti
Copy link
Member

@josedonizetti josedonizetti commented May 25, 2013

No description provided.

@atambo
Copy link
Member

@atambo atambo commented May 25, 2013

This change introduces the following rubyspec error:

     [java] IO.write disregards other options if :open_args is given ERROR
     [java] IOError: not opened for writing
     [java] org/jruby/RubyIO.java:1369:in `write'
     [java] org/jruby/RubyIO.java:3771:in `write'
     [java] /home/travis/build/jruby/jruby/spec/ruby/core/io/write_spec.rb:61:in `(root)'
     [java] org/jruby/RubyBasicObject.java:1531:in `instance_eval'
     [java] org/jruby/RubyEnumerable.java:1343:in `all?'
     [java] org/jruby/RubyFixnum.java:280:in `times'
     [java] org/jruby/RubyArray.java:1617:in `each'
     [java] /home/travis/build/jruby/jruby/spec/ruby/core/io/write_spec.rb:48:in `(root)'
     [java] /home/travis/build/jruby/jruby/spec/ruby/core/io/write_spec.rb:47:in `(root)'
     [java] org/jruby/RubyKernel.java:1073:in `load'
     [java] org/jruby/RubyBasicObject.java:1531:in `instance_eval'
     [java] org/jruby/RubyArray.java:1617:in `each'
@josedonizetti
Copy link
Member Author

@josedonizetti josedonizetti commented May 25, 2013

@atambo how did you simulate this error? Because my change is not supposed to make it happen, this error should be happening before because IO.write doesn't support "open_args" the specs for "open_args" are tagged. I was planing to support "open_args" after merging this pull request because make reviews easier.

atambo added a commit that referenced this pull request May 25, 2013
add support for options and not truncating offset for IO.write
@atambo atambo merged commit e812402 into jruby:master May 25, 2013
1 check was pending
1 check was pending
@headius
default The Travis CI build is in progress
Details
@josedonizetti josedonizetti deleted the josedonizetti:io_write branch May 25, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants